FocalPointControl: Add flag to remove bottom margin #43996
Merged
+50
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Sep 8, 2022
Comment on lines
+69
to
+77
| const extraHelpTextMargin = ( { | ||
| hasHelpText = false, | ||
| }: FocalPointPickerControlsProps ) => { | ||
| return hasHelpText | ||
| ? css` | ||
| padding-bottom: 1em; | ||
| ` | ||
| : undefined; | ||
| }; |
There was a problem hiding this comment.
I decided it was good to keep this extra bottom margin when there is a help text provided, because the whitespace is more balanced.
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38730
What?
Adds a
__nextHasNoMarginBottomprop to remove the bottom margin.Why?
Better reusability.
How?
Passes through the prop to BaseControl, as well as some special handling on
ControlWrapper, where there was some additional bottom margin being added.Testing Instructions
npm run storybook:devand see the story for FocalPointControl.